Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: retry prod test 3 times #485

Merged
merged 5 commits into from
Sep 18, 2023
Merged

ci: retry prod test 3 times #485

merged 5 commits into from
Sep 18, 2023

Conversation

JeremyTubongbanua
Copy link
Member

@JeremyTubongbanua JeremyTubongbanua commented Sep 18, 2023 •
edited
Loading

- What I did

  • sshnp entrypoint will attempt 3 times before completely failing, hopefully catches any RVD timeouts. See Prod Tests Flaky #484 on the problem this PR attempts to solve
  • chmod +x test.sh, now runs via ./test.sh instead of sh test.sh
  • removed -o StrictHostKeyChecking=no, since sshnp now appends -o StrictHostKeyChecking=accept-new

closes #484

- How to verify it

  • CI tests passing
  • Prod_tests workflow_dispatch on this branch are passing, 6 instances back-to-back have passed
    image

@JeremyTubongbanua JeremyTubongbanua self-assigned this Sep 18, 2023
@JeremyTubongbanua JeremyTubongbanua marked this pull request as draft September 18, 2023 14:36
@JeremyTubongbanua JeremyTubongbanua marked this pull request as ready for review September 18, 2023 14:46
@cpswan cpswan merged commit 19c56e2 into trunk Sep 18, 2023
35 checks passed
@cpswan cpswan deleted the jeremy-prod-tests-retry-3 branch September 18, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpswan cpswan cpswan approved these changes

@XavierChanth XavierChanth Awaiting requested review from XavierChanth

Assignees

@JeremyTubongbanua JeremyTubongbanua

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prod Tests Flaky
2 participants
@JeremyTubongbanua @cpswan